feat: add commands for publishing extensions#1140
feat: add commands for publishing extensions#1140martin-helmich wants to merge 14 commits intomasterfrom
Conversation
martin-helmich
force-pushed
the
feat/contributor-commands
branch
from
c88936f to
7850884
Compare
| typeof Publish, | ||
| void | ||
| > { | ||
| static description = "Publish an extension on the marketplace"; |
There was a problem hiding this comment.
The publishing of extensions will only work if verification has been requested and successfully completed beforehand.
I believe the corresponding route to request verification has not yet been published
There was a problem hiding this comment.
Can we rely on the API to respond with an appropriate and sensible error message in this case (in which case we could leave this as-is and just present the API error message), or should we catch that condition (successful verification) beforehand client-side?
There was a problem hiding this comment.
The API will likely respond with a reasonable error message. I just wanted to point out, the current flow will be interrupted by writing some mittwald guys to verify the extension (including starting the verification process) until the corresponding API route is published.
There was a problem hiding this comment.
In theory, we should be able to observe the verified/verificationRequested fields, of the extension, shouldn't we? In this case, we could present an appropriate warning after the deploy command when the user needs to take (additional, and/or atm. manual) verification steps. 🤔
2 participants
No description provided.