Skip to content

Fix logging/setLevel to return empty hash per MCP specification #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koic wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

Fix logging/setLevel to return empty hash per MCP specification #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/mcp/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,8 @@ def configure_logging_level(request)
end

@logging_message_notification = logging_message_notification

{}
end

def list_tools(request)
Expand Down
18 changes: 18 additions & 0 deletions test/mcp/server_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,24 @@ class Example < Tool
assert_instrumentation_data({ method: "resources/templates/list" })
end

test "#configure_logging_level returns empty hash on success" do
response = @server.handle(
{
jsonrpc: "2.0",
id: 1,
method: "logging/setLevel",
params: {
level: "info",
},
},
)

assert_equal "2.0", response[:jsonrpc]
assert_equal 1, response[:id]
assert_empty(response[:result])
refute response.key?(:error)
end

test "#configure_logging_level returns an error object when invalid log level is provided" do
server = Server.new(
tools: [TestTool],
Expand Down