Skip to content

Fix author name underline + fix gallery preference being broken #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prospector merged 2 commits into from
Feb 9, 2026
Merged

Fix author name underline + fix gallery preference being broken #5337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2bac7f
Fix author name underline + fix gallery preference being broken
Prospector Feb 9, 2026
2e5e5c7
Merge remote-tracking branch 'origin/main' into prospector/proj-card-…
Prospector Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/ui/src/components/base/SmartClickable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,6 @@ defineOptions({
// Setup base styles for contents
.smart-clickable__contents {
transition: scale 0.125s ease-out;

// Why? I don't know. It forces the SVGs to render differently, which fixes some shift on hover otherwise.
//filter: brightness(1.00001);
}

// When clickable is being hovered or focus-visible, give contents an effect
Expand All @@ -59,6 +56,12 @@ defineOptions({
:deep(.smart-clickable\:highlight-on-hover) {
filter: brightness(var(--hover-brightness, 1.25));
}
:deep(.smart-clickable\:surface-4-on-hover) {
@apply bg-surface-4;
}
:deep(.smart-clickable\:surface-5-on-hover) {
@apply bg-surface-5;
}
:deep(.ease-brightness) {
opacity: 0.85;
transition: opacity 0.125s ease-out;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/components/project/ProjectCardList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
withDefaults(
defineProps<{
layout?: 'list' | 'grid'
layout?: 'list' | 'grid' | 'gallery'
}>(),
{
layout: 'list',
Expand All @@ -13,7 +13,7 @@ withDefaults(
class="gap-3"
:class="{
'flex flex-col': layout === 'list',
'grid grid-project-list': layout === 'grid',
'grid grid-project-list': layout === 'grid' || layout === 'gallery',
}"
role="list"
>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/components/project/card/ProjectCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const props = defineProps<{
}>()
const baseCardStyle =
'w-full h-full border-[1px] border-solid border-surface-4 overflow-hidden bg-bg-raised rounded-2xl group transition-all smart-clickable:outline-on-focus smart-clickable:highlight-on-hover'
'w-full h-full border-[1px] border-solid border-surface-4 overflow-hidden bg-surface-3 rounded-2xl transition-all smart-clickable:outline-on-focus smart-clickable:highlight-on-hover'
const updatedDate = computed(() =>
props.dateUpdated ? dayjs(props.dateUpdated).toDate() : undefined,
Expand Down