Forward endpoint errors to httpsRequest#185
Open
felicienfrancois wants to merge 5 commits intomolnarg:masterfrom
Open
Forward endpoint errors to httpsRequest#185felicienfrancois wants to merge 5 commits intomolnarg:masterfrom
felicienfrancois wants to merge 5 commits intomolnarg:masterfrom
Conversation
Needed to be able to handles thoose errors gracefully because endpoint is not exposed.
Collaborator
|
Hrm, so for these, I think I would rather see some logging happen, as well, similar to how we do other errors that we forward on through other objects: Where That way we have symmetry in how we handle errors. |
Contributor
Author
|
@nwgh Ok, I just comitted the fix |
Contributor
Author
|
just a friendly bump :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to be able to handles thoose errors gracefully because endpoint is not exposed.