fix(settings): quick nav fails to open hide elements & danger zone (@byseif21)#7513
Open
byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
Open
fix(settings): quick nav fails to open hide elements & danger zone (@byseif21)#7513byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
byseif21 wants to merge 2 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where clicking "hide elements" or "danger zone" in the settings page quick navigation failed to expand collapsed sections.
Changes:
- Extract section group name from the
hrefattribute instead ofinnerTextto match CSS class names - Add validation to ensure href starts with "#group_" and is not empty after extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the settings page, clicking "hide elements" or "danger zone" from the top quick nav did not open those sections when they were collapsed, unlike the other quick nav links,
that's due to a mismatch between the visible label and the section’s class name.
Steps to reproduce