fix(test): prioritize "too short" over AFK detection for very short tests (@openvaibhav)#7519
Open
openvaibhav wants to merge 1 commit intomonkeytypegame:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Single word custom tests (e.g. "a" or "I") were incorrectly flagged as
"AFK detected" instead of "too short".
This happens because AFK validation was evaluated before the
"too short" validation inside the result checks chain.
Since both checks exist in the same "else if" chain, the first match wins.
Very short completed tests therefore triggered AFK before the
"too short" condition was reached.
This PR reorders the validation so that "too short" is evaluated
before AFK detection.
Reproduction
After Fix
The test correctly shows:
Test invalid - too short
instead of:
Test invalid - AFK detected
Technical Notes
No logic was modified, only validation priority was adjusted.
Duration mismatch and difficulty checks remain unaffected.
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCloses #7518