[code_review] Integrate ML filter for the generated comments#5077
Open
ArezouAmini wants to merge 6 commits intomozilla:masterfrom
Open
[code_review] Integrate ML filter for the generated comments#5077ArezouAmini wants to merge 6 commits intomozilla:masterfrom
ArezouAmini wants to merge 6 commits intomozilla:masterfrom
Conversation
ArezouAmini
requested review from
marco-c and
suhaibmujahid
and removed request for
marco-c and
suhaibmujahid
Member
suhaibmujahid
left a comment
suhaibmujahid
left a comment
There was a problem hiding this comment.
@ArezouAmini Thank you for submitting the PR!
Could you please clarify the relation between the three classes that you added?
Comment on lines
+4
to
+7
| import torch | ||
| from datasets import Dataset | ||
| from torch.nn.functional import softmax | ||
| from transformers import ( |
Member
There was a problem hiding this comment.
I think some of the dependencies are not in the requirements.json.
| self.tmpdir = tmpdir | ||
|
|
||
| @abstractmethod | ||
| def train_test_split(self, data, test_size=0.5, random_split=True): ... |
Member
There was a problem hiding this comment.
What should the data look like? I do not see the method used anywhere!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.