Conversation
build: update dependencies
16e4e74 to
4dedf4b
Compare
tessstoddard
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
After upgrading to Spring Boot 3.x (Spring Framework 6.2.x), we observed that path connectors were returning false-positive
200 OKresponses with empty bodies when certain client disconnected exceptions were thrown (e.g.EOFExceptionorIOException: Broken pipe).This change was tracked down to a new feature in Spring 6.2's
DefaultHandlerExceptionResolver. To suppress noisy logs, Spring now delegates tohandleDisconnectedClientException(), which returns an emptyModelAndViewobject. Because a non-nullModelAndViewis returned, theDispatcherServletassumes the error was handled successfully, suppresses the exception, and instructs the servlet container to return a standard 200 response.This MR fixes the regression by bypassing this suppression. It introduces a new
WebMvcConfigurerthat swaps out the default exception resolver with an implementation that returnsnullfor disconnected clients. This restores the legacy (pre-6.2) behavior, forcing theDispatcherServletto re-throw the exception so it can be properly handled and logged by our existingErrorHandlerFilter/ErrorHandlerchain.Fixes GCU-1218
Public API Additions/Changes
N/A
Downstream Consumer Impact
Downstream consumers and services relying on the
mdx-webproject will no longer experience silent200 OKresponses when a network connection drops. The application will behave exactly as it did in Spring Boot 2.7.x, allowing disconnected client exceptions to bubble out of the Spring context and into our custom servlet filters.There are no breaking changes to consumer APIs or interfaces, and no migration steps are required for downstream code.
How Has This Been Tested?
I pulled a snapshot version into path-connector-globalcu and modified the
ProfileAccessor#getmethod to explicitly throw an exception that would be suppressed by Spring's new error handling.In
ProfileAccessor:Calling the get profile endpoint prior to my changes produced a false-positive
200 OKresponse:After my changes, it produced an expected error response:
Checklist: