List just artist's albums instead of albums and songs#282
Open
rivaldi8 wants to merge 1 commit intonaman14:masterfrom
Open
List just artist's albums instead of albums and songs#282rivaldi8 wants to merge 1 commit intonaman14:masterfrom
rivaldi8 wants to merge 1 commit intonaman14:masterfrom
Conversation
Contributor
|
Any reason this branches off 15 commits behind naman14:master head instead of from naman14:master head directly? |
rivaldi8
force-pushed
the
list-artist-albums-grid
branch
from
b79e7da to
644b45b
Compare
Contributor
Author
|
Sorry, somehow I forgot to sync my master with upstream. I've rebased the branch properly now. |
Owner
|
@rivaldi8 I am still not sure about this change, however i do agree with your view on this. I think it will be good if we can keep the albums in grid on top followed by the songs. I will test different layouts for this to work properly |
Contributor
Author
|
@naman14 Having the album grid at the top followed by songs would be good enough for me :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I want to listen to some music I usually look for a specific album from an artist. So I look for the artist, then for the album, then I start playing it.
ArtistMusicFragment displays the list of albums horizontally with all the artist's songs below. For artists with a large discography it's cumbersome to scroll horizontally to find an album.
This pull requests make ArtistMusicFragment list just the albums in a grid. It would remain to add a fake album as the first entry with all the artist songs to facilitate when the user doesn't care about the album. To keep this PR small I've left it off for a future PR, in case you accept this one.