A few changes to build as dynamic lib and support 64bit better#2
Open
jeremyfa wants to merge 5 commits intonative-toolkit:masterfrom
Open
A few changes to build as dynamic lib and support 64bit better#2jeremyfa wants to merge 5 commits intonative-toolkit:masterfrom
jeremyfa wants to merge 5 commits intonative-toolkit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been using a fork of openal-android for a while because I needed to make a few changes in it:
Be able to build openal as a dynamic library which is not merged with the rest of the app binary and improve compliance with LGPL license. The library can still be linked statically with
-D static_linklike before. I have been using openal without issues this way (as a linc_library, butlibopenal.solinked separately) for many months now, so I consider it working.Patch configuration (
include/config.h) when targeting arm64 and x86_64 because previous configuration was expected to work only on 32bit targets (so far, even though it seems that this implementation of openal was not optimized for 64bit, it does seem to work fine in my tests with the config change). Didn't test on x86_64 yet, but result should be similar to arm64.These changes could be useful for everyone, so here is my PR.