Fix compilation on newer android NDKs#4
Open
justin-espedal wants to merge 2 commits intonative-toolkit:masterfrom
Open
Fix compilation on newer android NDKs#4justin-espedal wants to merge 2 commits intonative-toolkit:masterfrom
justin-espedal wants to merge 2 commits intonative-toolkit:masterfrom
Conversation
__NDK_MAJOR__ is present for NDK 16+. NDK 19+ includes log2f.
log2f is available in the arm64 headers.
|
Works for me on NDK 21, but not NDK 15. I had to combine new and old code to make it work in both cases. I'll submit my own pull request if needed, but I'm pretty sure you can just cherry-pick my commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compilation with NDK 21, at least. I can't guarantee other versions, but NDK 15 still works as well.
__NDK_MAJOR__is present for NDK 16+.NDK 19+ includes
log2f.