Conversation
Testing the case of localOnly files. As the deletion logic differs per scenario, tests for the online scenario will also need to be added. Signed-off-by: Philipp Hasper <vcs@hasper.info>
Otherwise, the localOnly file deletion will not update the UI. Signed-off-by: Philipp Hasper <vcs@hasper.info>
The remote + offline test case had to be ignored due to two reasons 1) Broken App behavior - The UX is indeed broken, as from a user perspective, nothing happens with the file when deleting it. The offlineOperation is put on the worker stack, but the user doesn't see anything from it - Even when coming back online, it is completely unreliable when the deletion will be finally done. It might happen 5 or 10 minutes later 2) Broken test mock - The mocked connectivityService doesn't work as expected, because the OfflineOperationsWorker has its own service, and thus might still execute the deletion, but just at an unforseable time during the test execution - see problem 1). Signed-off-by: Philipp Hasper <vcs@hasper.info>
…e list The existing test cases varied by configuration: local vs. remote, online vs. offline. This is now extended by also starting at different entry points: beginning, end and middle of the list. Signed-off-by: Philipp Hasper <vcs@hasper.info>
Signed-off-by: Philipp Hasper <vcs@hasper.info>
| } | ||
| onView(isRoot()).check(matches(isDisplayed())) | ||
|
|
||
| assertTrue("Do not merge - just testing test failures", false) |
There was a problem hiding this comment.
This is where I provoke the failure
There was a problem hiding this comment.
This was not catched - https://drone.nextcloud.com/nextcloud/android/27697 ran through. And no other test job failed, either.
For reference, this is the overview of GitHub's checks for this commit, but somehow it does not show the drone action... Very confusing... https://github.com/nextcloud/android/pull/16329/checks?sha=71ac686c47076f8d24c71eae1bdcadf06214eeba
But as this view confusingly doesn't list the Drone job, I'll leave this screenshot as well, at the state of this commit. Drone job is shown green:
| onView(allOf(withText(loadingText), isDisplayed())) | ||
| .check(doesNotExist()) | ||
|
|
||
| assertTrue("Do not merge - just testing test failures", false) |
There was a problem hiding this comment.
This is the second failure I provoke
There was a problem hiding this comment.
This also wasn't catched - https://drone.nextcloud.com/nextcloud/android/27788 ran through and no other test job ran the test either.
For reference, this is the overview of checks for this commit: https://github.com/nextcloud/android/pull/16329/checks?sha=0becd054d1b3eefad3327626ea3d5b79cf397eba.
And the screenshot
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16329.apk |
| .perform(RecyclerViewActions.scrollToLastPosition<GalleryRowHolder>()) | ||
| .perform(RecyclerViewActions.scrollToPosition<GalleryRowHolder>(0)) | ||
|
|
||
| assertTrue("Do not merge - just testing test failures", false) |
There was a problem hiding this comment.
This is the third failure I provoke
There was a problem hiding this comment.
Drone also passed: https://drone.nextcloud.com/nextcloud/android/27789.
Check overview: https://github.com/nextcloud/android/pull/16329/checks?sha=dbd4897d8a21b0bd17d993c030074091f6e4e3c4
And screenshot of the PR overview:
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
1 participant
DO NOT MERGE - Just testing whether the tests added from the following PR's would actually fail the CI, if they uncovered an issue:
#16297#16296#16267