fix(assistant): resolve LocalContext resource query in LaunchedEffect#16466
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
fix(assistant): resolve LocalContext resource query in LaunchedEffect#16466joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Extract string resource retrieval outside LaunchedEffect to ensure proper recomposition on configuration changes. This resolves the LocalContextGetResourceValueCall lint warning and prevents stale snackbar messages when configuration changes occur (e.g., language switches, dark mode toggles). The snackbar message string is now computed in the composable body where LocalContext.current changes trigger recomposition, ensuring the LaunchedEffect always receives up-to-date string values. Fixes lint error: "Querying resource values using LocalContext.current" Signed-off-by: Josh <josh.t.richards@gmail.com>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16466.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lint error:
"Querying resource values using LocalContext.current"Extract string resource retrieval outside
LaunchedEffectto ensure proper recomposition on configuration changes. This resolves theLocalContextGetResourceValueCalllint error and prevents stale snackbar messages when configuration changes occur (e.g., language switches, dark mode toggles).The snackbar message string is now computed in the composable body where
LocalContext.currentchanges trigger recomposition, ensuring theLaunchedEffectalways receives up-to-date string values.