fix: use positional formatter specifiers for auto_upload_worker_start_text

[joshtrichards]

Fixes a bunch of lint warnings¹ and ensures argument ordering is locale away for this string (at least once all the other languages updates flow through).

Cc: @rakekniven (for the below):

A follow-up is needed on Transifex to fix the remaining one by someone on the ug/Uyghur translation team:

• The other one, for uploader_upload_in_progress_content is specific to the values-ug/strings.xml and will need to be fixed in Transifex:

android/app/src/main/res/values-ug/strings.xml

Line 1101 in 46a98da

<string name="uploader_upload_in_progress_content">%1$d %% يۈكلەش% 2 %2$s</string>

I believe it should be something like:

<string name="uploader_upload_in_progress_content">%1$d%% يېڭىلىۋاتىدۇ%2$s</string>

English source:

https://github.com/nextcloud/android/blame/46a98daae3a82977db070179bfcd35a70afb574b/app/src/main/res/values/strings.xml#L283

• Tests written, or not not needed

Footnotes

1. From CI/CI check (lint) output:
   /home/runner/work/android/android/app/src/main/res/values-in/strings.xml:105:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values/strings.xml:862:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-it/strings.xml:110:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-ru/strings.xml:118:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-sk-rSK/strings.xml:112:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-sr/strings.xml:106:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-sv/strings.xml:109:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-da/strings.xml:104:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-uk/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-zh-rTW/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-lo/strings.xml:108:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-hu-rHU/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-ug/strings.xml:111:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-is/strings.xml:100:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-ug/strings.xml:1101:4: Multiple substitutions specified in non-positional format of string resource string/uploader_upload_in_progress_content. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-fr/strings.xml:112:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-cs-rCZ/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-nl/strings.xml:99:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-ga/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-pt-rBR/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-de/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-et-rEE/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-b+en+001/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-gl/strings.xml:121:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-zh-rHK/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-sw/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-tr/strings.xml:113:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-es/strings.xml:103:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-zh-rCN/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-ja-rJP/strings.xml:106:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute?
   /home/runner/work/android/android/app/src/main/res/values-pl/strings.xml:120:4: Multiple substitutions specified in non-positional format of string resource string/auto_upload_worker_start_text. Did you mean to add the formatted="false" attribute? ↩

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16467.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.