Skip to content

fix(manifest): Move camera2 feature declaration to scan-enabled flavors#16468

Open
joshtrichards wants to merge 4 commits intomasterfrom
jtr/fix-camera2-manifest-build-overrides
Open

fix(manifest): Move camera2 feature declaration to scan-enabled flavors#16468
joshtrichards wants to merge 4 commits intomasterfrom
jtr/fix-camera2-manifest-build-overrides

Conversation

@joshtrichards
Copy link
Member

Moving to flavor-specific manifests to avoid warning about tools:node="replace" for builds that don't have scanning/camera2

Eliminates this check (lint) warning:

> Task :app:processGenericDebugMainManifest
/home/runner/work/android/android/app/src/debug/AndroidManifest.xml Warning:
	uses-feature#android.hardware.camera2 was tagged at AndroidManifest.xml:0 to replace another declaration but no other declaration present
  • Tests written, or not not needed

Moving to flavor-specific manifests to avoid warning about `tools:node="replace"` for builds that don't have scanning/camera2

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@github-actions
Copy link

github-actions bot commented Feb 7, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16468.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger
Copy link
Member

Hi @joshtrichards @alperozturk96 since we have a general upload Pic via cam in the fab's bottom sheet I would have expected that it is needed in all flavors. Or are we using something else there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants