refactor: remove deprecated getCurrentAccount() from interface#16484
Open
joshtrichards wants to merge 3 commits intomasterfrom
Open
refactor: remove deprecated getCurrentAccount() from interface#16484joshtrichards wants to merge 3 commits intomasterfrom
joshtrichards wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…ovider Remove getCurrentAccount() method from CurrentAccountProvider interface. The method was deprecated in favor of getUser() and had only one external caller (DrawerActivity), which has been migrated to use getUser() instead. The implementation in UserAccountManagerImpl remains as it's still used internally by getUser(), but removing it from the interface prevents new code from depending on the deprecated Account-based API. Refs: #4853, #4835 Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
3. to review
technical debt
feature: authentication
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
getCurrentAccount()method fromCurrentAccountProviderinterface.The method was deprecated in favor of
getUser()and had only one externalcaller (
DrawerActivity), which has been migrated to usegetUser()instead.The implementation in
UserAccountManagerImplremains as it's still usedinternally by
getUser(), but removing it from the interface prevents newcode from depending on the deprecated Account-based API.
Refs: #4853, #4835
🖼️ Screenshots
🏁 Checklist