This dynamic require is a no-go in webpack environments#34
Open
implausible wants to merge 1 commit intomasterfrom
Open
This dynamic require is a no-go in webpack environments#34implausible wants to merge 1 commit intomasterfrom
implausible wants to merge 1 commit intomasterfrom
Conversation
Member
|
Bummer, I think it could be fixed to work, but given this is meant for NodeGit I'm okay with the change. |
|
Any timeline on when we might be able to have this merged in? Looking forward to using this with webpack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is convenient, it makes the library difficult to use with webpack and other bundlers.