Pass addFile() response from cloudfiles to callback (instead of true)#50
Open
fearphage wants to merge 2 commits intonodejitsu:masterfrom
Open
Pass addFile() response from cloudfiles to callback (instead of true)#50fearphage wants to merge 2 commits intonodejitsu:masterfrom
true)#50fearphage wants to merge 2 commits intonodejitsu:masterfrom
Conversation
Member
|
Sorry for the delay here! We've been waiting on all the issues / pull-requests for https://github.com/nodejitsu/pkgcloud We added a deprecation notice for this library, but would you consider reimplementing your pull-request for the Rackspace provider in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
trueto theaddFilecallback causes a loss of data.Use Case
I'd like to access the etag header in the response. The etag is an md5sum of the uploaded file. I can compare this to my local file to verify the upload was successful.