-
Notifications
You must be signed in to change notification settings - Fork 25
chore(cli): remove interactive #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
+ Coverage 80.66% 80.80% +0.14%
==========================================
Files 128 126 -2
Lines 12392 12073 -319
Branches 887 874 -13
==========================================
- Hits 9996 9756 -240
+ Misses 2393 2314 -79
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
orama-db.json |
8.03 MB | 8.03 MB | -1.85 KB (-0.02%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the interactive CLI feature from the doc-kit tool, simplifying the command-line interface to focus solely on the generate command.
Changes:
- Removed
@clack/promptsdependency and associated interactive CLI implementation - Refactored the
generatecommand from the old prompt-based structure to a direct Commander.js command - Simplified CLI command registration logic
- Removed command type definitions and tests that were specific to the interactive system
Reviewed changes
Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed @clack/prompts dependency |
| npm-shrinkwrap.json | Removed @clack/prompts, @clack/core, and sisteransi packages; updated peer dependency flags |
| bin/commands/types.d.ts | Deleted - Type definitions for old command structure with prompts no longer needed |
| bin/commands/interactive.mjs | Deleted - Removed interactive CLI wizard implementation |
| bin/commands/index.mjs | Removed interactive command from exports, now only exports generate command |
| bin/commands/generate.mjs | Refactored from old object-based structure with prompts to Commander.js Command object |
| bin/commands/tests/index.test.mjs | Deleted - Tests for old command structure no longer applicable |
| bin/cli.mjs | Simplified command registration to use addCommand() directly instead of manual option processing |
Files not reviewed (1)
- npm-shrinkwrap.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /** | ||
| * @type {import('./types').Command} | ||
| */ | ||
| export default { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually prefer this way of defining the options, ngl.
This PR removes the interactive CLI