Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 74.25% 73.75% -0.51%
==========================================
Files 34 34
Lines 4999 5181 +182
==========================================
+ Hits 3712 3821 +109
- Misses 1287 1360 +73 ☔ View full report in Codecov by Sentry. |
| # Is `/usr/lib/lib` here correct? | ||
| sudo mkdir -p /usr/lib/lib/python${python_version} | ||
| sudo ln -s /usr/lib/llvm-${{ matrix.llvm }}/lib/python${python_version}/site-packages /usr/lib/lib/python${python_version}/site-packages |
There was a problem hiding this comment.
Left a comment here, not sure what symlinking to /usr/lib/lib is doing?
| sudo apt-get install lldb-11 liblldb-11-dev lcov -y | ||
| sudo ln -s $(which lldb-11) /usr/bin/lldb |
There was a problem hiding this comment.
Updated these to lldb-11 because ubuntu-latest is now jammy
| use_llvm_repos=1 | ||
|
|
||
| case "${{ matrix.os }}-${{ matrix.llvm }}" in | ||
| ubuntu-18.04-10) use_llvm_repos=1;; | ||
| ubuntu-18.04-11) use_llvm_repos=1;; | ||
| ubuntu-18.04-12) use_llvm_repos=1;; | ||
| ubuntu-18.04-13) use_llvm_repos=1;; | ||
| ubuntu-18.04-14) use_llvm_repos=1;; | ||
| ubuntu-20.04-13) use_llvm_repos=1;; | ||
| ubuntu-20.04-14) use_llvm_repos=1;; | ||
| *) use_llvm_repos=0;; | ||
| case "${{ matrix.os }}" in | ||
| ubuntu-18.04) | ||
| case "${{ matrix.llvm }}" in | ||
| 8) use_llvm_repos=0;; | ||
| 9) use_llvm_repos=0;; | ||
| 10) use_llvm_repos=0;; | ||
| *) use_llvm_repos=1;; | ||
| esac | ||
| ;; | ||
| ubuntu-20.04) | ||
| case "${{ matrix.llvm }}" in | ||
| 8) use_llvm_repos=0;; | ||
| 9) use_llvm_repos=0;; | ||
| 10) use_llvm_repos=0;; | ||
| 11) use_llvm_repos=0;; | ||
| 12) use_llvm_repos=0;; | ||
| *) use_llvm_repos=1;; | ||
| esac | ||
| ;; | ||
| ubuntu-22.04) | ||
| case "${{ matrix.llvm }}" in | ||
| 11) use_llvm_repos=0;; | ||
| 12) use_llvm_repos=0;; | ||
| 13) use_llvm_repos=0;; | ||
| 14) use_llvm_repos=0;; | ||
| 15) use_llvm_repos=0;; | ||
| *) use_llvm_repos=1;; | ||
| esac | ||
| ;; | ||
| *) use_llvm_repos=1;; |
There was a problem hiding this comment.
This defaults to using the LLVM repos unless it's one of the versions packaged by Canonical. This should be a limited set, compared to the previous way which would need exceptions for every version not packaged by Canonical.
|
It appears the lldb headers in llvm-19 now include headers generated by the build, so downloading them from github is insufficient to build llnode. I'm not sure what to do about that. @No9 do you have any thoughts on this PR? |
2 participants
This is a followup to #389:
lldbversion is the current dev releaserelease/XY.xbranch, but does have allvmorg-XY-inittagIf we wanted to be fancy, we could populate the supported versions and CI matrix by parsing
git ls-remote --tags https://github.com/llvm/llvm-project.git 'refs/tags/llvmorg-*-init'.Let me know if that's something you'd like me to add!