feat: add ConstructorTraitTag to allow constructor return overridding#1670
feat: add ConstructorTraitTag to allow constructor return overridding#1670legendecas wants to merge 1 commit intonodejs:mainfrom
Conversation
f97cb22 to
6c7c39f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1670 +/- ##
=======================================
Coverage 65.79% 65.79%
=======================================
Files 3 3
Lines 2146 2149 +3
Branches 715 716 +1
=======================================
+ Hits 1412 1414 +2
Misses 162 162
- Partials 572 573 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c7c39f to
d07f9d7
Compare
|
This does not work for |
|
Thank you for working on this! It's not clear from the comments if this is working yet. It sounds like maybe not? I would suggest adding a few more tests
|
Hi @legendecas , is there anything we can do to address this branch check? Is it absolutely needed? |
Fixes: #1661