This repository was archived by the owner on Feb 1, 2022. It is now read-only.
Conversation
Update ESLint and tap to quell warnings from `npm audit` and the GitHub interface. ESLint update required some changes to other files as indentation rules are now more strictly enforced. I'm seeing tests failing locally but that was the case before I updated anything too, so hopefully this passes on Travis-CI or whatever.
Collaborator
|
Let me see if I can get some level of CI back online for this repo. The old ci.nodejs.org build broke a while ago and since then I have been doing ad-hoc checks only. I assume that for travis it would take an admin to enable it? |
Member
Author
I'm honestly not sure, but you are an admin for this repo, so hopefully whatever is required, you have the appropriate permissions. |
Collaborator
|
Created an issue in the build repo for that: nodejs/build#1868. But that doesn't have to block merging this PR. |
hybrist
approved these changes
Jul 19, 2019
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ESLint and tap to quell warnings from
npm auditand theGitHub interface.
ESLint update required some changes to other files as indentation rules
are now more strictly enforced.
I'm seeing tests failing locally but that was the case before I updated
anything too, so hopefully this passes on Travis-CI or whatever.