This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Escape version strings passed to regular expression matchers#147
Open
richardlau wants to merge 1 commit intonodejs:mainfrom
Open
Escape version strings passed to regular expression matchers#147richardlau wants to merge 1 commit intonodejs:mainfrom
richardlau wants to merge 1 commit intonodejs:mainfrom
Conversation
Version strings in `process.versions` should be escaped before being used to construct regular expressions. Fixes tests when run against current Node.js master branch where OpenSSL has a `+` character in its version string.
Member
Author
|
CI: https://ci.nodejs.org/view/post-mortem/job/test-nodereport/41/ (:heavy_check_mark:) |
Member
Author
|
CI against master showing failures with Node.js 15: https://ci.nodejs.org/job/nodereport-continuous-integration-latest/219/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version strings in
process.versionsshould be escaped before beingused to construct regular expressions. Fixes tests when run against
current Node.js master branch where OpenSSL has a
+character inits version string.
Refs: nodejs/citgm#852 (comment)