Added method to set 'mutable-content' to 1. Fixes #321, #328.#331
Open
cemcatik wants to merge 2 commits intonotnoop:masterfrom
Open
Added method to set 'mutable-content' to 1. Fixes #321, #328.#331cemcatik wants to merge 2 commits intonotnoop:masterfrom
cemcatik wants to merge 2 commits intonotnoop:masterfrom
Conversation
Author
|
Any idea how to resolve the timeout error? It's not related to this changelist and I can't repro locally. |
grippy
reviewed
Apr 11, 2017
| return this; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
While this comment below is helpful, I would delete it since it doesn't have anything to setting mutable-content.
Author
There was a problem hiding this comment.
Looks like it's just auto-formatted the javadoc of the .method below. I'll clean it up in a bit. Thanks
cemcatik
force-pushed
the
mutable-content
branch
from
9d51fd5 to
01cd207
Compare
cemcatik
force-pushed
the
mutable-content
branch
from
01cd207 to
27f7817
Compare
grippy
approved these changes
Apr 11, 2017
grippy
left a comment
grippy
left a comment
There was a problem hiding this comment.
Looks good! Hoping this gets merged & released in the near future 😄
|
any one merging this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.