[ssh-completion] Support blocks that define more than one Host#1223
Open
LostExcalibur wants to merge 1 commit intonushell:mainfrom
Open
[ssh-completion] Support blocks that define more than one Host#1223LostExcalibur wants to merge 1 commit intonushell:mainfrom
LostExcalibur wants to merge 1 commit intonushell:mainfrom
Conversation
It is a valid ssh config to have a block defining properties for more than one host, such as : Host home home-git other-on-same-addr HostName example.com This correctly parses such configs.
Contributor
|
@hongquan you changed this file last in a similar place. What do you think about these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a valid ssh config to have a block defining properties for more than one host, such as :
This correctly parses such configs.
I also took the liberty to fix the annoying "HostName" text that was appearing in front of the actual hostname in the completion, because
findwas not called with-nand thus the splitting was done incorrectly.