This repository was archived by the owner on Dec 7, 2025. It is now read-only.
Disambiguage field and method "keys" with the same name#1
Merged
glepnir merged 2 commits intonvimdev:mainfrom May 18, 2025
Merged
Disambiguage field and method "keys" with the same name#1glepnir merged 2 commits intonvimdev:mainfrom
glepnir merged 2 commits intonvimdev:mainfrom
Conversation
added 2 commits
May 16, 2025 10:53
The method "keys" raised an error that I was trying to call a table. I just renamed the field "keys" to "mappings'.
a trigger to load the plugin.
Member
|
Isn't this duplicate of #2? |
Author
|
I am sorry. I made two commits in succession and pushed them both to the PR. This is the first ever PR of my life, I am striving to learn what I can. |
Member
|
no worry :) I wonder why change to mappings? most plugin managers use |
Author
|
In my machine, Neovim was saying that I could not call a table. The internal field was renamed to "mappings" just to make it different from the class method with the same name. |
Author
|
Now I am wondering if, depending on how we use the plugin, the method is assigned to the table after the field so the method is call correctly and give a false-positive to the user. |
Member
|
I misunderstand LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.