Pass TLS configt to the gRPC server#871
Open
pavolloffay wants to merge 1 commit intoobservatorium:mainfrom
Open
Pass TLS configt to the gRPC server#871pavolloffay wants to merge 1 commit intoobservatorium:mainfrom
pavolloffay wants to merge 1 commit intoobservatorium:mainfrom
Conversation
Member
What is this? |
Member
Author
|
@squat I have updated the PR description |
e086889 to
8f7b5ad
Compare
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
8f7b5ad to
542d448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TLS settings should be properly passed to all service APIs (e.g. gRPC in this case).
This bug was discovered during TLS testing of grafana/tempo-operator#1367 (comment). Which implements the TLS requirements from openshift-eng/ai-helpers#316
Pushed to
pavolloffay/api:main-2026-02-11-v0.1.2-669-g0532e43-dirty