Update omniauth strategy to pass location#78
Open
marcusguttenplan wants to merge 2 commits intoomniauth:masterfrom
Open
Update omniauth strategy to pass location#78marcusguttenplan wants to merge 2 commits intoomniauth:masterfrom
marcusguttenplan wants to merge 2 commits intoomniauth:masterfrom
Conversation
|
+1 |
Author
|
Sadly this project isn't being actively maintained and I don't have write access. Feel free to use my fork if that works for you! It's a super minimal change. |
Member
|
@marcusguttenplan thanks for submitting this PR. I just started reviewing old PRs here, and we can merge yours if you add a small spec to check if the |
Member
|
@marcusguttenplan are you still interested in getting this merged? We just need a spec added. |
Author
|
I can tackle this soon, sorry for the delay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding additional
locationfield fromraw_infoto the object that is created so that it better fits into Omniauth's Auto Hash Schema