respect dtypes of input file#557
Conversation
|
Nice, thank you! Would it be possible add a simple test to ensure the dtypes are propagated? |
|
Yes. I'll try :) |
|
It looks good, but the test actually fails... Does it work for you locally? |
|
Yes, also just noticed. Was a premature push. i did not think about the rearranged pixels after calling |
|
Fixed it by simply leaving the chromosome order as is and just checking if dtypes are equal. This now passes locally and I also fails when dtypes are not equal |
tests/test_rearrange_cooler.py
Outdated
| assert np.array_equal(old_trans_m, reordered_inverted_trans_m, equal_nan=True) | ||
|
|
||
| # IV. | ||
| # Check that pixel datatypes are propagted to output cooler |
There was a problem hiding this comment.
thanks for pointing this out. already fixed it
|
Thanks for the review and sorry for the inability to type straight^^ |
|
haha no worries! Thank you for the PR, I'll merge it! |
|
Great :) Always happy to help making the ecosystem better ;). Have a nice day |
2 participants
This is a fix for #556