[ENH] V1 → V2 API Migration - estimation procedures#1604
[ENH] V1 → V2 API Migration - estimation procedures#1604EmanAbdelhaleem wants to merge 71 commits intoopenml:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
+ Coverage 52.04% 54.73% +2.69%
==========================================
Files 36 63 +27
Lines 4333 5070 +737
==========================================
+ Hits 2255 2775 +520
- Misses 2078 2295 +217 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #...
Depends on #1576
Related to #1575
geetu040
left a comment
There was a problem hiding this comment.
Can you please take a look at the function _get_estimation_procedure_list in tasks/functions and see if it can also be replaced via the list method or a new method in EstimationProcedures class?
2f6aa34 to
94d1163
Compare
for more information, see https://pre-commit.ci
This reverts commit fd43c48.
f8c4791 to
0d9868a
Compare
|
@geetu040 Ready for review |
Fixes #1622
Depends on #1576
Related to: #1575
Details
This PR implements
EstimationProceduresresource, and refactor its existing functions