[ENH] V1 -> V2 Migration - Flows (module)#1609
Open
Omswastik-11 wants to merge 106 commits intoopenml:mainfrom
Open
[ENH] V1 -> V2 Migration - Flows (module)#1609Omswastik-11 wants to merge 106 commits intoopenml:mainfrom
Omswastik-11 wants to merge 106 commits intoopenml:mainfrom
Conversation
Omswastik-11
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1609 +/- ##
==========================================
+ Coverage 52.04% 54.25% +2.21%
==========================================
Files 36 63 +27
Lines 4333 5096 +763
==========================================
+ Hits 2255 2765 +510
- Misses 2078 2331 +253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Omswastik-11
commented
Jan 14, 2026
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Omswastik-11
force-pushed
the
flow-migration-stacked
branch
from
614411f to
36184e5
Compare
for more information, see https://pre-commit.ci
Contributor
Author
|
Hi @geetu040 !! Can you review the pre-commit failure It was due to merge conflicts more specifically for tasks . Should I change it on my branch ? |
Collaborator
can you try again, sync your branch with mine? It should be fixed now. |
Contributor
Author
|
I think that due to conflicts it did not synced properly . I have to revert it manually |
geetu040
suggested changes
Jan 15, 2026
Collaborator
geetu040
left a comment
geetu040
left a comment
There was a problem hiding this comment.
Nice overall, few changes needed. I'll look at the tests later when the implementation is final.
Co-authored-by: Armaghan Shakir <raoarmaghanshakir040@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
This reverts commit fd43c48.
…into flow-migration-stacked # Conflicts: # openml/_api/setup/config.py
- removing this since it was not part of the sdk previously - some tests fail because of the timeout in stacked PRs - this option can easily be added if needed in future
…into flow-migration-stacked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1601
added a
Createmethod inFlowAPIfor publishing flow but not refactored with oldpublish. (Needs discussion on this)Added tests using
fake_methodsso that we can test without localV2server . I have tested theFlowsV2methods (getandexists) anddeleteandlistwere not implemented inV2server so I skipped them .