Open
Conversation
for more information, see https://pre-commit.ci
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
+ Coverage 52.04% 52.24% +0.20%
==========================================
Files 36 64 +28
Lines 4333 5141 +808
==========================================
+ Hits 2255 2686 +431
- Misses 2078 2455 +377 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
…-11/openml-python into runs-migration-stacked
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
Signed-off-by: Omswastik-11 <omswastikpanda11@gmail.com>
This reverts commit fd43c48.
…into runs-migration-stacked
openml/_api/resources/run.py
Outdated
| OpenMLNotSupportedError | ||
| V2 server API not yet available for this operation. | ||
| """ | ||
| raise OpenMLNotSupportedError("not implemented yet on V2 server") |
Contributor
There was a problem hiding this comment.
I think we need to use self._not_supported(method="...") instead.
Please check point num. 8 here #1575 (comment)
openml/_api/resources/run.py
Outdated
| OpenMLNotSupportedError | ||
| V2 server API not yet available for this operation. | ||
| """ | ||
| raise OpenMLNotSupportedError("not implemented yet on V2 server") |
openml/_api/resources/run.py
Outdated
| V2 server does not yet support POST /runs/ endpoint. | ||
| Expected availability: Q2 2025 | ||
| """ | ||
| raise OpenMLNotSupportedError("not implemented yet on V2 server") |
openml/_api/resources/run.py
Outdated
| xml_content = response.text | ||
| return openml.runs.functions._create_run_from_xml(xml_content) | ||
|
|
||
| def list( # type: ignore[valid-type] # noqa: PLR0913, C901, PLR0912 |
Contributor
There was a problem hiding this comment.
I think we can split this into 3 functions for more readability:
- list()
- _build_url()
- _parse_list_xml()
check #1606 for reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata
Details
fixes #1624