[ENH] V1 → V2 API Migration - setups#1619
Open
EmanAbdelhaleem wants to merge 77 commits intoopenml:mainfrom
Open
[ENH] V1 → V2 API Migration - setups#1619EmanAbdelhaleem wants to merge 77 commits intoopenml:mainfrom
EmanAbdelhaleem wants to merge 77 commits intoopenml:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
==========================================
+ Coverage 52.04% 54.46% +2.42%
==========================================
Files 36 63 +27
Lines 4333 5064 +731
==========================================
+ Hits 2255 2758 +503
- Misses 2078 2306 +228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Running the tests for both files: To reproduce: |
This reverts commit fd43c48.
Contributor
Author
|
@geetu040 Ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1625
Depends on #1576
Related to #1575
Details
This PR implements
Setupsresource, and refactor its existing functions