-
-
Notifications
You must be signed in to change notification settings - Fork 215
[ENH] Allow using a local test server #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
83e1531
f90036d
3a257ab
3b79017
f524d75
a5601e3
d862be2
16699e6
775dcf7
319cb35
a680ebe
b161b3b
0b989d1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -415,9 +415,10 @@ def get_task( | |
| if not isinstance(task_id, int): | ||
| raise TypeError(f"Task id should be integer, is {type(task_id)}") | ||
|
|
||
| cache_key_dir = openml.utils._create_cache_directory_for_id(TASKS_CACHE_DIR_NAME, task_id) | ||
| tid_cache_dir = cache_key_dir / str(task_id) | ||
| tid_cache_dir_existed = tid_cache_dir.exists() | ||
| task_cache_directory = openml.utils._create_cache_directory_for_id( | ||
| TASKS_CACHE_DIR_NAME, task_id | ||
| ) | ||
| task_cache_directory_existed = task_cache_directory.exists() | ||
| try: | ||
| task = _get_task_description(task_id) | ||
| dataset = get_dataset(task.dataset_id, **get_dataset_kwargs) | ||
|
|
@@ -431,8 +432,8 @@ def get_task( | |
| if download_splits and isinstance(task, OpenMLSupervisedTask): | ||
| task.download_split() | ||
| except Exception as e: | ||
| if not tid_cache_dir_existed: | ||
| openml.utils._remove_cache_dir_for_id(TASKS_CACHE_DIR_NAME, tid_cache_dir) | ||
| if not task_cache_directory_existed: | ||
| openml.utils._remove_cache_dir_for_id(TASKS_CACHE_DIR_NAME, task_cache_directory) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. .. and therefore remove the complete directory, instead of the specific task. is that intentional? |
||
| raise e | ||
|
|
||
| return task | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| org/openml/test | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why this symlink is uploaded? probably a mistake? or is this used for linking remote-test-server cache with local-test-server cache. if this was intentional, can I ask what's it's purpose and this path can't be tracked on windows because of the leads to CI failure on windows: job/61983305389 |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
task_cache_directorynow points to the folder with all the tasks instead of the folder with the specific task ...