✨ Add regression test cases for DeploymentConfig options

[trgeiger]

Description

Updates generate-manifests.go to include test cases for each option type in DeploymentConfig as well as a test case with all DeploymentConfig options.

Updates the testdata/expected-manifests/ directory with all the new test case manifests.

Large number of file changes is entirely due to all the new manifests for each test case in testdata/expected-manifests/. Review should mainly focus on generate-manifests.go changes.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	333b58d
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69864c3497e320000857da35
😎 Deploy Preview	https://deploy-preview-2493--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tmshort for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

❌ Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.70%. Comparing base (6e01665) to head (333b58d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
test/regression/convert/generate-manifests.go	0.00%	133 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2493      +/-   ##
==========================================
- Coverage   73.68%   68.70%   -4.99%     
==========================================
  Files         102      102              
  Lines        8471     8601     +130     
==========================================
- Hits         6242     5909     -333     
- Misses       1749     2220     +471     
+ Partials      480      472       -8     

Flag	Coverage Δ
e2e	46.29% <ø> (ø)
experimental-e2e	12.94% <ø> (-41.00%)	⬇️
unit	56.98% <0.00%> (-0.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[anik120]

🎉 thanks for the PR!

I wonder if we loose anything if we just combine all of the options into one?

This is a lot of test manifests we'll have to store in the repository if we break them down individually.

From POV it's sufficient to include one test with ALL of the configuration options, and list in a comment what the individual options are.

[trgeiger]

Yeah that's totally fair. I just was following the objectives as laid out in the OPRUN ticket but I had wondered the same thing, that just the combined case is really needed.