Типизация исключений, проброс причин, небольшой рефакторинг#15
Merged
Типизация исключений, проброс причин, небольшой рефакторинг#15
Conversation
…чтобы отличить assertation fault от прочих исключений * Для утверждений проверяющих выполнение метода, добавлен проброс оригинального исключения в причину исключения asserts для второй версии движка * Для Ожидаем.Содержит() добавлена поддержка коллекций CollectionOS * Небольшой рефакторинг
There was a problem hiding this comment.
Pull Request Overview
This PR adds exception typing and cause propagation to the assertions library, along with CollectionOS support for the Содержит method. The changes improve error diagnostics by making assertion failures distinguishable from other exceptions and by preserving original exception information in OneScript 2.0+.
- Added
ИсключениеОшибкаУтвержденияclass to type assertion failures - Exception cause propagation now supported for OneScript 2.0+
- CollectionOS collections now supported in
Содержит()assertions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packagedef | Version bumped to 1.6.0, added ИсключениеОшибкаУтверждения class definition, added collectionos as development dependency |
| tests/bdd-assertions-tests.os | Added test to verify exception cause propagation in error messages |
| tests/bdd-assertions-identity-tests.os | Updated test assertion text to match new error message format for type mismatches |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nixel2007
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.