Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
external-subnets-ui
branch
from
e865ae2 to
9d8bc0f
Compare
david-crespo
force-pushed
the
external-subnets-ui
branch
from
9d8bc0f to
cf41314
Compare
Contributor
|
Great! I don't see any grave UI crimes, but I'll take a look later. We have a subnet icon already too. |
| cell: (info) => <span className="text-secondary">{info.getValue()}</span>, | ||
| }), | ||
| colHelper.accessor('instanceId', { | ||
| header: 'Attached to instance', |
Contributor
There was a problem hiding this comment.
Table header crime! "Attached to" would be reasonable. Floating IPs also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP but it's pretty damn good. Does not cover subnet pools on the operator side. Would need an icon for the sidebar. Needs an endpoint for listing linked subnet pools, see oxidecomputer/omicron#9814.