BUGFIX: Fix nested View All page#102
Closed
novascreen wants to merge 1 commit intopattern-lab:masterfrom
Closed
Conversation
|
In our composer.json I had to do the following to get this through all of the dependencies: but then I was able to pull in the correct commit without conflict. |
3 tasks
|
Thanks @novascreen for the PR and @frobo for the configuration advice! I was getting errors when I put exactly what @froboy recommended, but after trying a few things, this worked for me: "require": {
"php": ">=5.4",
"pattern-lab/core": "dev-dev#c976fa4cbffac7a67c41df43f47899d09a965a49",
"pattern-lab/patternengine-twig": "dev-dev",
"pattern-lab/styleguidekit-twig-default": "^3.0.0"
}, |
|
Thanks all. I'm using mustache rather than twig, so I don't know if this would have worked for @KatieMFritz and @froboy. But I just changed one line of |
4 tasks
Member
|
All fixed now as of v2.8.0!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On View All pages like for all Atoms or Molecules the general-footer is missing. The address bar, menu and pattern lab elements on the page break.
I believe this is the commit which broke things: 67c193d
I also think this might be related to pattern-lab/patternlab-php#370 and pattern-lab/styleguidekit-assets-default#41
Sorry for the messup on the previous PR.