feat: allow full-page example utils to change position#4896
feat: allow full-page example utils to change position#4896thatblindgeye merged 8 commits intomainfrom
Conversation
Deploying patternfly-org with
|
| Latest commit: |
3396b87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18e1b277.patternfly-org.pages.dev |
| Branch Preview URL: | https://full-page-utils-position.patternfly-org.pages.dev |
mcoker
force-pushed
the
full-page-utils-position
branch
from
39db2d3 to
adcd7ff
Compare
|
@bekah-stephens whenever you get a sec, updated to put the buttons in the padding like we discussed. Also changed the icon for the current position so it's a little more obvious. wdyt? |
andrew-ronaldson
left a comment
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Tooltips on the buttons are a plus but okay to do in a follow up
mcoker
force-pushed
the
full-page-utils-position
branch
from
adcd7ff to
1d460e2
Compare
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
lgtm! Local storage seems to be working fine as well (changed theme and menu position and both were the same after closing and reopening the link).
There was a problem hiding this comment.
Also noticing an outline on a button when it's selected in High Contrast mode. That might be confused with a focus ring (I definitely did not try clicking elsewhere on the page several times to remove focus from it 🙈 ). This might be fine for high contrast, though, not something we need to deal with in this PR.
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
Just one quick update needed below, otherwise LGTM and the corner buttons look fabulous 🤩
Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
8 participants
fixes #4892
Preview - can be seen on any full page example:
https://pf-org--pr-4896-site.surge.sh/ai/generative-uis/compass/html-demos/card-view/
This adds something pretty simple. Not sure how to add this without it taking up the entire switcher. Seems like maybe we need a label or something? Not sure - @bekah-stephens wdyt?