fix: use NewDocumentConfiguration() as default config in BuildV3Model #528
+58
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling NewDocument() (without explicit configuration), BuildV3Model() was creating a bare DocumentConfiguration struct literal as the fallback. This meant all bool fields defaulted to false (Go zero values), causing TransformSiblingRefs and MergeReferencedProperties to be silently disabled. BuildV2Model() already correctly uses datamodel.NewDocumentConfiguration() as its fallback. This aligns BuildV3Model() to do the same, ensuring features like sibling $ref -> allOf transformation are enabled by default regardless of which NewDocument constructor is used. Fixes: pb33f#90 Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 99.56% 99.56% -0.01%
==========================================
Files 192 192
Lines 23878 23874 -4
==========================================
- Hits 23775 23769 -6
- Misses 62 64 +2
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling NewDocument() (without explicit configuration), BuildV3Model() was creating a bare DocumentConfiguration struct literal as the fallback. This meant all bool fields defaulted to false (Go zero values), causing TransformSiblingRefs and MergeReferencedProperties to be silently disabled.
BuildV2Model() already correctly uses datamodel.NewDocumentConfiguration() as its fallback. This aligns BuildV3Model() to do the same, ensuring features like sibling $ref -> allOf transformation are enabled by default regardless of which NewDocument constructor is used.
Fixes: #90