Conversation
|
thanks for the pull request. i triggered a build and the phpstan error is also happening on 2.x branch: #251 can you check why the LTS build fails? we can drop 4.4 build if that is problematic, but 5.4, 6.4 and 7.4 should still work. from the error it looks like something in the setup for the test is not right when 7.4 fails because 8.0 |
| - symfony: '7.0.*' | ||
| php-version: '8.2' | ||
| - symfony: '7.4.*' | ||
| php-version: '8.3' |
There was a problem hiding this comment.
the build error might be related to what happens when we use php 8.3 instead of 8.2, or because we require 7.4 instead of 7.0. 7.4 has no stable release yet, do we need to allow dev versions for the 7.4 and 8.0 build?
There was a problem hiding this comment.
I'm not sure why 7.4 fail ; I'll try to remove 7.4 first to see if it works on 8.0 first.
Anyway I discover it will be block by https://github.com/phpspec/phpspec
There was a problem hiding this comment.
i started the build. and thanks for starting phpspec/phpspec#1498, lets hope that can be wrapped up quickly.
the 8.0 build fails because of phpspec.
There was a problem hiding this comment.
i converted the tests to phpunit :-|
|
please add |
What's in this PR?
Hi @dbu,
I'm adding support for SF8
Checklist