Fix: Resolve accessibility violation by adding explicit role to offcanvas menu#1787
Merged
derickr merged 1 commit intophp:masterfrom Feb 4, 2026
Merged
Fix: Resolve accessibility violation by adding explicit role to offcanvas menu#1787derickr merged 1 commit intophp:masterfrom
derickr merged 1 commit intophp:masterfrom
Conversation
Contributor
|
🚀 Preview for commit 33fc835 can be found at https://web-php-pr-1787.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit 33fc835 is at https://web-php-regression-report-pr-1787.preview.thephp.foundation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an accessibility violation on website homepage identified by the IBM Equal Access Accessibility Checker.
The offcanvas navigation container (
.navbar__offcanvas) was using anaria-label="Menu"without an explicit ARIA role. According to WAI-ARIA standards, a<div>with a generic role should not typically have an accessible name.Violation Details
<div>with implicit ARIA role generic.Fix
By adding
role="navigation", we ensure that:aria-labelis valid and properly exposed to assistive technologies.Verify
Additional Info
The patch submitted in this PR was generated by A11YRepair, an automated Web Accessibility repair tool that I developed to address common accessibility violations in web applications. The generated fixes were manually reviewed and validated before submission.