Open
Conversation
eseiker
requested review from
Atralupus and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR adds the "thor" validator to the list of supported validators and removes the unused HEADLESS_URLS constant. The codebase architecture separates concerns by storing validator URLs statically in Constants while fetching headless node URLs dynamically from the planet registry API. The removed HEADLESS_URLS dictionary was redundant as headless URLs are already retrieved via PlanetRegistryClient.
Key Changes:
- Added "thor" validator with its GraphQL endpoint to
VALIDATOR_URLS - Removed the entire
HEADLESS_URLSconstant dictionary containing 7 hardcoded headless and validator URLs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added thor validator and removed unused headless urls (fetched via planet registry)
eseiker
force-pushed
the
eseiker-patch-1
branch
from
5a87e0d to
9f25cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added thor validator and removed unused headless urls (fetched via planet registry)