Adjust Chrome flags in CI to fix broken jobs#7700
Merged
Conversation
…me is actually used by karma
emilykl
commented
Jan 29, 2026
| // window-size values came from observing default size | ||
| // | ||
| // '--ignore-gpu-blacklist' allow to test WebGL on CI (!!!) | ||
| // '--ignore-gpu-blocklist' allow to test WebGL on CI (!!!) |
Contributor
Author
There was a problem hiding this comment.
The blacklist -> blocklist change is because Chrome renamed the flag
camdecoster
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Looks good. I added one suggestion that might be an alternative config. Here's a relevant doc page.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Contributor
Author
|
@camdecoster Good call, looks like Just working on getting the CircleCI tests to pass, I think it's just the usual flakiness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime in January it seems there was a change in some of the Chrome defaults relating to the GPU.
https://github.com/orgs/community/discussions/185629
https://issues.chromium.org/issues/476172421
It seems those changes are causing our "NoCI" GitHub Actions workflow to fail on some of the WebGL tests.
This PR:
Adjusts the flags used to run the Chrome process in the GitHub Actions workflow, to correctly use simulated GPU rendering (GHA runners do not have GPU by default)
Adjusts the "NoCI" workflow to use the Chrome executable downloaded by the
setup-chromestep rather than the one pre-baked intoubuntu-latest. This will make the Chrome version more up-to-date, as well as allow us to pin a specific Chrome version if we desire.