Modifying whatIs() to allow for scalar or array objects#40
Open
jackdeguest wants to merge 1 commit intopmqs:masterfrom
Open
Modifying whatIs() to allow for scalar or array objects#40jackdeguest wants to merge 1 commit intopmqs:masterfrom
jackdeguest wants to merge 1 commit intopmqs:masterfrom
Conversation
Owner
|
I avoided allowing any blessed references when I wrote this code because you have no idea what is lurking behind the reference. Need to think about this proposal, plus it will need documented & the unit tests updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a scalar object, i.e. a blessed scalar reference,
IO::Uncompress::Gunzip::gunzipand I suspect the other member of theIO::Compressfamily as well, rejects it with the errorillegal input parameter.It would be nice that it recognises those as scalar reference.
For example, consider the following code:
Before change, this would yield:
And after change:
ok