Skip to content

PostgresConfigurationFactory_Base is corrected #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Feb 24, 2026
Merged

PostgresConfigurationFactory_Base is corrected #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 7 additions & 23 deletions src/implementation/v00/configuration_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3096,23 +3096,20 @@ def Helper__CreateObject(
objectParent, PostgresConfigurationObject
)

typeOfObjectData = type(objectData)
assert typeOfObjectData is not None

if typeOfObjectData == PgCfgModel__ConfigurationData:
if type(objectData) is PgCfgModel__ConfigurationData:
assert objectData is cfg.m_Data
return cfg

if typeOfObjectData == PgCfgModel__FileData:
if type(objectData) is PgCfgModel__FileData:
return __class__.Helper__CreateFile(objectData, objectParent)

if typeOfObjectData == PgCfgModel__FileLineData:
if type(objectData) is PgCfgModel__FileLineData:
return __class__.Helper__CreateFileLine(objectData, objectParent)

if typeOfObjectData == PgCfgModel__OptionData:
if type(objectData) is PgCfgModel__OptionData:
return __class__.Helper__CreateOption(objectData, objectParent)

BugCheckError.UnkObjectDataType(typeOfObjectData)
BugCheckError.UnkObjectDataType(type(objectData))

# --------------------------------------------------------------------
@staticmethod
Expand All @@ -3137,33 +3134,20 @@ def Helper__CreateFile(
def Helper__CreateFileLine(
objectData: PgCfgModel__FileLineData,
objectParent: PostgresConfigurationObject,
) -> PostgresConfigurationFile_Base:
) -> PostgresConfigurationFileLine_Base:
assert objectData is not None
assert objectParent is not None
assert type(objectData) is PgCfgModel__FileLineData
assert isinstance(objectParent, PostgresConfigurationFile_Base)

return PostgresConfigurationFileLine_Base(objectParent, objectData)

# --------------------------------------------------------------------
@staticmethod
def Helper__CreateFileLineComment(
fileLineDataItem: PgCfgModel__FileLineData.tagItem,
fileLine: PostgresConfigurationObject,
) -> PostgresConfigurationFile_Base:
assert fileLineDataItem is not None
assert fileLine is not None
assert type(fileLineDataItem) is PgCfgModel__FileLineData.tagItem
assert isinstance(fileLine, PostgresConfigurationFileLine_Base)

return PostgresConfigurationComment_Base(fileLine, fileLineDataItem)

# --------------------------------------------------------------------
@staticmethod
def Helper__CreateOption(
objectData: PgCfgModel__OptionData,
objectParent: PostgresConfigurationObject,
) -> PostgresConfigurationFile_Base:
) -> PostgresConfigurationOption_Base:
assert objectData is not None
assert objectParent is not None
assert type(objectData) is PgCfgModel__OptionData
Expand Down