Skip to content

Comments

run sonar analysis on tags#71

Open
khouadrired wants to merge 2 commits intomainfrom
run-sonar-analysis-on-tags
Open

run sonar analysis on tags#71
khouadrired wants to merge 2 commits intomainfrom
run-sonar-analysis-on-tags

Conversation

@khouadrired
Copy link

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

What kind of change does this PR introduce?
feature

What is the current behavior?
Sonar analysis are executed on the main branch

What is the new behavior (if this is a feature change)?
Sonar analysis are executed on the release / patch branch

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Radouane Khouadri <redouane.khouadri_externe@rte-france.com>
@khouadrired khouadrired force-pushed the run-sonar-analysis-on-tags branch from e77c870 to 3fbd7b5 Compare February 20, 2026 11:16
uses: SonarSource/sonarqube-scan-action@aa494459d7c39c106cc77b166de8b4250a32bb97 # v5.1.0
env:
SONAR_TOKEN: ${{ secrets.sonar-token }}
with:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed for build?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , deleted

Copy link
Collaborator

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want that for front end lib, back end lib

Signed-off-by: Radouane Khouadri <redouane.khouadri_externe@rte-france.com>
@khouadrired khouadrired force-pushed the run-sonar-analysis-on-tags branch from 84b72a0 to 5c71cb3 Compare February 20, 2026 12:10
- name: Install Dependencies
run: npm ci

- name: SonarCloud Analysis
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for patch frontend lib?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no patch file for frontend lib.

@jonenst
Copy link
Collaborator

jonenst commented Feb 20, 2026

conceptually OK ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants