Add SUPFILE_DIR as default environment variable#176
Open
stengaard wants to merge 2 commits intopressly:masterfrom
Open
Add SUPFILE_DIR as default environment variable#176stengaard wants to merge 2 commits intopressly:masterfrom
stengaard wants to merge 2 commits intopressly:masterfrom
Conversation
This will allow Supfiles to be run different directories and consistently resolve files relative to the Supfile. This CL contains refactors the resolution order of environment variables such that it's a bit easier to reason about. Fixes pressly#99
Commit 1595c1d accidentally removed the lines that resolve env var values. This adds env var resolution and adds a test to assert the behavior.
|
@VojtechVitek any chance this can be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow Supfiles to be run different directories and
consistently resolve files relative to the Supfile.
This CL contains refactors the resolution order of environment
variables such that it's a bit easier to reason about.
Fixes #99