amtool: command to test receivers#4807
Draft
SoloJacobs wants to merge 18 commits intoprometheus:mainfrom
Draft
Conversation
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Co-authored-by: Solomon Jacobs <solomonjacobs@protonmail.com> Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Oktarian TB <oktotb@gmail.com> Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
* Update logging * Add argument to notify.NewIntegration Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
SoloJacobs
changed the title
Contributor
|
I gave it a try, its a useful helper. I know you did not add additional code on purpose yet. But I think we should at least include all notifiers that are in the current main branch. I noticed at least teamsv2 and rocketchat missing. |
TheMeier
approved these changes
Feb 1, 2026
Contributor
|
@SoloJacobs can you rebase that? |
siavashs
reviewed
Feb 10, 2026
Contributor
siavashs
left a comment
siavashs
left a comment
There was a problem hiding this comment.
@SoloJacobs please write an elaborative PR description. While it is possible to go through the nested list of PRs, it is better to have all the context here and only link to the historical ones.
I think we are also missing the documentation for this.
I added a few other comments in the code as well.
| @@ -0,0 +1,309 @@ | |||
| // Copyright 2022 Prometheus Team | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2022 Prometheus Team | |
| // Copyright The Prometheus Authors |
Comment on lines
+268
to
+270
| for i, c := range nc.WebhookConfigs { | ||
| add("webhook", i, c, func(l *slog.Logger) (notify.Notifier, error) { return webhook.New(c, tmpl, l) }) | ||
| } |
Contributor
There was a problem hiding this comment.
Doing this per receiver seems excessive to me.
We should instead just have one call to a module to add all the configured receivers.
Otherwise this logic will be always missing one or more receivers in future.
| @@ -0,0 +1,119 @@ | |||
| // Copyright 2022 Prometheus Team | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2022 Prometheus Team | |
| // Copyright The Prometheus Authors |
| @@ -0,0 +1,58 @@ | |||
| // Copyright 2022 Prometheus Team | |||
Contributor
There was a problem hiding this comment.
Suggested change
| // Copyright 2022 Prometheus Team | |
| // Copyright The Prometheus Authors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an update of #3491 that's updated to work against main, which in turn is an update of #3139 .
So far, I have held off on making some changes myself, except for what was necessary to get CI green again. I also have a small laundry list of things I would fix here, but I would like a second pair of eyes on this request first.