Modify put function to support a time that exceeds setTimeout's maximum time#88
Open
gilruben wants to merge 6 commits intoptarjan:masterfrom
Open
Modify put function to support a time that exceeds setTimeout's maximum time#88gilruben wants to merge 6 commits intoptarjan:masterfrom
gilruben wants to merge 6 commits intoptarjan:masterfrom
Conversation
Author
|
@ptarjan please check this out please |
Author
|
@ptarjan I fixed the merge conflict |
|
@ptarjan merge this pr and release a new version please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setTimeout can support a maximum of 2147483647 milliseconds (about 24.9 days), which limits the time that the put function can support. Now it can support the maximum safe integer supported by the javascript number primitive (9007199254740991). 9007199254740991 milliseconds is about 285616.41 years.